Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPM support #30

Merged
merged 3 commits into from
Jan 17, 2018
Merged

SPM support #30

merged 3 commits into from
Jan 17, 2018

Conversation

frederoni
Copy link
Contributor

@frederoni frederoni commented Jan 12, 2018 •
edited
Loading

Fixes #29 - Support for Swift Package Manager and adds support for Linux 🐧

Would be nice to add integration tests before merging this or at least a swift build/test step.

@1ec5 👀

1ec5
1ec5 reviewed Jan 12, 2018
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Builds are failing because the INFOPLIST_FILE build setting needs to be updated.

@1ec5 1ec5 added the build label Jan 12, 2018
@frederoni frederoni force-pushed the fred-spm branch 6 times, most recently from c003c95 to b8d7577 Compare January 15, 2018 02:10
@frederoni
Copy link
Contributor Author

frederoni commented Jan 15, 2018 •
edited
Loading

Tests for Linux will have to wait until SPM supports bundled resources. https://bugs.swift.org/browse/SR-2866

1ec5
1ec5 approved these changes Jan 16, 2018
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. 😿

@frederoni frederoni merged commit af657e1 into master Jan 17, 2018
@frederoni frederoni deleted the fred-spm branch January 17, 2018 10:48
@1ec5
Copy link
Contributor

1ec5 commented Jan 18, 2018

This will net us 15 points on CocoaPods’ quality estimate scale. 🏆

@frederoni frederoni mentioned this pull request Jan 19, 2018
Merged
@1ec5 1ec5 mentioned this pull request Jul 29, 2019
Open
@1ec5 1ec5 mentioned this pull request Sep 16, 2020
Closed
16 tasks
@1ec5 1ec5 mentioned this pull request Nov 5, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederoni @1ec5